On Fri, 2 Feb 2024 21:17:48 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:

>> test/jdk/jdk/nio/zipfs/TestPosix.java line 757:
>> 
>>> 755:         try (FileSystem fs = FileSystems.newFileSystem(ZIP_FILE, 
>>> ENV_POSIX)) {
>>> 756:             Path path = fs.getPath("hello.txt");
>>> 757:             Files.setPosixFilePermissions(path, 
>>> EnumSet.of(OWNER_READ));
>> 
>> It might be helpful to show the before/after output of the CEN fields here 
>> just for extra clarity
>
>> It might be helpful to show the before/after output of the CEN fields here 
>> just for extra clarity
> 
> Thanks! Can you take a look at 4bb77e1 which shows the `zipdetails` output 
> for relevant fields before/after calling `setPosixFilePermissions`.

thank you Looks good

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17556#discussion_r1476753283

Reply via email to