On Mon, 5 Feb 2024 17:23:54 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed CodeBuilder::newObject methods > > src/java.base/share/classes/java/lang/classfile/CodeBuilder.java line 507: > >> 505: * @return this builder >> 506: */ >> 507: default CodeBuilder newObject(ClassEntry type) { > > The two `newObject` methods seem to fit in the pattern of methods that are > being removed, since they don't differentiate sufficiently with the `new_` > methods that defer to them. Right, we can remove also the `newObject` and keep `new_` methods, thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17282#discussion_r1478638191