On Mon, 19 Feb 2024 13:17:48 GMT, Goetz Lindenmaier <go...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Typo >> - Merge branch 'master' into JDK-8325579 >> - Rename test and refine comment >> - Enhance test >> - JDK-8325579 > > test/jdk/com/sun/jndi/ldap/LdapSSLHandshakeTest.java line 224: > >> 222: >> 223: public CustomSocket(String s, int timeout) throws IOException { >> 224: super(s, timeout); > > The argument should be called "port" not timeout. Correct. > test/jdk/com/sun/jndi/ldap/LdapSSLHandshakeTest.java line 246: > >> 244: >> 245: @Override >> 246: public Socket createSocket(String s, int timeout) throws >> IOException { > > The argument should be "int port" instead of timeout. Right. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17797#discussion_r1495579995 PR Review Comment: https://git.openjdk.org/jdk/pull/17797#discussion_r1495579746