On Mon, 26 Feb 2024 19:10:39 GMT, Jorn Vernee <jver...@openjdk.org> wrote:

>> test/jdk/java/foreign/TestLayouts.java line 164:
>> 
>>> 162:         );
>>> 163:         assertEquals(struct.byteSize(), 1 + 1 + 2 + 4 + 8);
>>> 164:         assertEquals(struct.byteAlignment(), 8);
>> 
>> Looking at this PR:
>> https://github.com/openjdk/jdk/pull/18007
>> 
>> This test seemed to cover more case before that PR - e.g. a layout generator 
>> was tweaked to exclude long/doubles. I believe revert the test changes now?
>
> That doesn't seem to be the right PR link?

Found the right one: 
https://github.com/openjdk/jdk/commit/44218b1c9e5daa33557aac9336251cf8398d81eb

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18007#discussion_r1503166930

Reply via email to