On Thu, 29 Feb 2024 21:00:09 GMT, Joe Wang <jo...@openjdk.org> wrote:

> Fix a NPE when a validating parser is restricted by the JDKCatalog resolve 
> property. Also slightly improved the error msg with the catalog name.
> 
> Test: new test added
>          existing test CatalogSupport5 would fail without the Null check on 
> ErrorReporter. It's a separate issue not covered by this fix.

LGTM

src/java.xml/share/classes/jdk/xml/internal/SecuritySupport.java line 402:

> 400:         int i = input.lastIndexOf('/');
> 401:         if (i > 0) {
> 402:             return input.substring(i+1, input.length());

Nit: the second argument is not needed.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18071#pullrequestreview-1910127344
PR Review Comment: https://git.openjdk.org/jdk/pull/18071#discussion_r1508361029

Reply via email to