On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Fixing test cases. For bad test cases, only the first case was run, and the
> rest were ignored.
Looks good.
Only a trivial suggestion.
test/jdk/java/lang/Double/ParseDouble.java line 564:
> 562: check(input[i]);
> 563: }
> 564: catch (NumberFormatException e) {
The `catch` clause doesn't need to stay in a new line.
test/jdk/java/lang/Float/ParseFloat.java line 284:
> 282: check(input[i]);
> 283: }
> 284: catch (NumberFormatException e) {
The `catch` clause doesn't need to stay in a new line.
-------------
Marked as reviewed by gli (Committer).
PR Review: https://git.openjdk.org/jdk/pull/18113#pullrequestreview-1917117778
PR Review Comment: https://git.openjdk.org/jdk/pull/18113#discussion_r1512898093
PR Review Comment: https://git.openjdk.org/jdk/pull/18113#discussion_r1512899151
