On Wed, 6 Mar 2024 00:56:16 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> I believe we could technically reuse the list for boot/platform modules. >> But, the intent here is to provide more control over the modules with native >> access, not only being able to add to the list, but also remove from the >> list. So, to me, it seemed better to have an explicit list, from/to which we >> can remove/add modules easily. > > Hello Jan, my suggestion was based on a misunderstanding that > NATIVE_ACCESS_MODULES is always a superset of boot and platform modules. What > you currently have looks fine to me. And also, for the record, the .conf files are supposed to be in a syntactical subset compatible with both bash and make syntax, so this would not have been possible anyway. :) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18106#discussion_r1514865999
