On Thu, 7 Mar 2024 06:50:04 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more alignment > > src/hotspot/share/cds/cdsConfig.cpp line 2: > >> 1: /* >> 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. > > Incorrect copyright update - should be "2023, 2024," Fixed. > src/hotspot/share/cds/cdsConfig.cpp line 54: > >> 52: (is_dumping_static_archive() ? IS_DUMPING_STATIC_ARCHIVE >> : 0) | >> 53: (is_logging_lambda_form_invokers() ? >> IS_LOGGING_LAMBDA_FORM_INVOKERS : 0) | >> 54: (is_using_archive() ? IS_USING_ARCHIVE : 0); > > You can remove one space before the ? in each line Fixed. > src/hotspot/share/cds/cdsConfig.hpp line 56: > >> 54: static const int IS_DUMPING_STATIC_ARCHIVE = 1 << 1; >> 55: static const int IS_LOGGING_LAMBDA_FORM_INVOKERS = 1 << 2; >> 56: static const int IS_USING_ARCHIVE = 1 << 3; > > why is the = sign so far away? Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18095#discussion_r1516811557 PR Review Comment: https://git.openjdk.org/jdk/pull/18095#discussion_r1516811622 PR Review Comment: https://git.openjdk.org/jdk/pull/18095#discussion_r1516811711
