On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Currently, our symbol visibility handling for tests are sloppy; we only >> handle it properly on Windows. We need to bring it up to the same levels as >> product code. This is a prerequisite for >> [JDK-8327045](https://bugs.openjdk.org/browse/JDK-8327045), which in turn is >> a building block for Hermetic Java. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Update line number for dereference_null in TestDwarf Looks like a nice cleanup - great to see all the duplicated EXPORT code gone! test/hotspot/jtreg/runtime/ErrorHandling/libTestDwarfHelper.h line 24: > 22: */ > 23: > 24: #include <stdio.h> Seems unneeded. test/hotspot/jtreg/runtime/ErrorHandling/libTestDwarfHelper.h line 27: > 25: > 26: #include "export.h" > 27: #include "jni.h" Seems unneeded. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18135#pullrequestreview-1926822024 PR Review Comment: https://git.openjdk.org/jdk/pull/18135#discussion_r1519075894 PR Review Comment: https://git.openjdk.org/jdk/pull/18135#discussion_r1519076039
