On Tue, 12 Mar 2024 21:52:31 GMT, Elif Aslan <d...@openjdk.org> wrote:
> This change enables to run JspawnhelperProtocol.java on MacOS. > > In addition to GHA , the test has been run on macos and linux. > > > Test report is stored in > build/macosx-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_ProcessBuilder_JspawnhelperProtocol_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration > 'macosx-x86_64-server-fastdebug' > > > > > > Test report is stored in > build/linux-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_ProcessBuilder_JspawnhelperProtocol_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping javac server > [ec2-user@ip-172-16-0-10 jdk]$ make test CONF=linux-x86_64-server-fastdebug > TEST=test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java LGTM Just a reminder to keep that the PR description is copied into every email sent so it should be concise. Extended descriptions and additional details should be added in a separate comment. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18253#pullrequestreview-1934219262
