On Tue, 27 Feb 2024 22:06:12 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Only show runtime image suffix for JDK modules > > make/autoconf/spec.gmk.template line 904: > >> 902: RL_INTERMEDIATE_IMAGE_SUBDIR := runtime-link-initial-jdk >> 903: RL_INTERMEDIATE_IMAGE_DIR := >> $(IMAGES_OUTPUTDIR)/$(RL_INTERMEDIATE_IMAGE_SUBDIR) >> 904: > > This intermediate directory is only used inside the Images.gmk. I don't think > we need to define it in spec. It can be a local variable in Images.gmk. Also, > unless you really want this intermediate image in "images" as some kind of > deliverable I would prefer to put it somewhere under > `$(SUPPORT_OUTPUTDIR)/images`. Fixed in the update. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1524964780
