On Tue, 12 Mar 2024 14:03:01 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> restore comment > > I think splitting `CharArraySequence` into two versions is somewhat dubious > as more observable types at call sites may mean the performance gain in > targeted micros is lost. How much of an improvement did you observe from > this? Again the `char[]` constructors is probably less performance sensitive > than the others. > @cl4es @jddarcy All feedback has been fixed, can it be integrated? Hello @wenshao , This change will need additional review from myself or others who maintain BigDecimal before it can be integrated. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18177#issuecomment-2007967764