On Tue, 19 Mar 2024 16:01:34 GMT, Aleksei Efimov <aefi...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Update module-info text >> - Merge branch 'master' into JDK-8325579 >> - Indentation >> - Merge branch 'master' into JDK-8325579 >> - Review feedback >> - Rename back to LdapSSLHandshakeFailureTest to ease reviewing >> - Merge branch 'master' into JDK-8325579 >> - Typo >> - Merge branch 'master' into JDK-8325579 >> - Rename test and refine comment >> - ... and 2 more: https://git.openjdk.org/jdk/compare/b172eb4c...10271159 > > src/java.naming/share/classes/module-info.java line 42: > >> 40: * <br>The value of this environment property specifies the fully >> 41: * qualified class name of the socket factory used by the LDAP >> provider. >> 42: * This class must implement the javax.net.SocketFactory >> abstract class > > You could add a link to the `SocketFactory` class here: > Suggestion: > > * This class must implement the {@link javax.net.SocketFactory} > abstract class Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17797#discussion_r1532877183
