On Fri, 29 Mar 2024 17:43:36 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make cendsk an unsigned short
>
> src/java.base/share/native/libjli/parse_manifest.c line 505:
>
>> 503: Byte *base = p + CENHDR + CENNAM(p);
>> 504: jlong offset = 0;
>> 505: while (offset < cenext) {
>
> Any reason why a loop is need here?
There can be multiple extra fields, and the zip64 extended information may not
be the first one
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18479#discussion_r1544730915
