On Mon, 1 Apr 2024 23:37:21 GMT, Tim Prinzing <tprinz...@openjdk.org> wrote:
>> Currently the JFR event FileForceEvent is generated by instrumenting the
>> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer
>> mirror events with static methods.
>>
>> Added the event at jdk.internal.event.FileForceEvent, and changed
>> jdk.jfr.events.FileForceEvent to be a mirror event.
>>
>> Updated FileChannelImpl to use the jdk internal event static methods, and
>> removed the force() method from FileChannelImplInstrumentor.
>>
>> Uses the existing tests.
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add support for AsynchronousFileChannel.force().
src/java.base/share/classes/jdk/internal/event/FileForceEvent.java line 35:
> 33: * {@link #commit(long, long, String, boolean)} method
> 34: * must be the same as the order of the fields.
> 35: */
You may have to re-word this comment to avoid confusion with the metaData
parameter. That is, there is event metaData and there is file metaData, if you
see what I mean.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18542#discussion_r1547136136
