On Thu, 4 Apr 2024 17:35:43 GMT, Mandy Chung <[email protected]> wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add jtreg test case
>
> test/jdk/java/lang/RuntimeTests/loadLibrary/LoadLibraryTestAIX.java line 38:
>
>> 36: } catch (Exception e) {
>> 37: throw new RuntimeException("LoadLibraryTestAIX : could not
>> load libperfstat.a"+e);
>> 38: }
>
> Nit: the catch clause is not strictly needed. `UnsatisfiedLinkError` is an
> unchecked exception. The test should fail if you run it with JDK without
> this fix.
The test should verify if `/usr/lib/libperstat.a` is present and also
`/usr/lib/libperfstat.so` is not present.
Do you expect all AIX machines do not have `/usr/lib/libperfstat.so`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1552140344
