On Thu, 4 Apr 2024 16:47:07 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 2235:
>
>> 2233: }
>> 2234: sym.adr = nextadr;
>> 2235: vars[nextadr] = sym;
>
> could we use a record here? these two arrays seem to be in sync
Sure, done. Thanks for the comment!
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java
> line 1364:
>
>> 1362:
>> 1363: @Override
>> 1364: public void visitDerivedInstance(JCDerivedInstance tree) {
>
> I was expecting this code to belong to Lower, not saying that it is wrong
> here though but probably more naturally in Lower I think
Moved to `Lower`. Thanks for the comment!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18509#discussion_r1553545686
PR Review Comment: https://git.openjdk.org/jdk/pull/18509#discussion_r1553546716
