On Tue, 16 Apr 2024 17:06:50 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains five commits:
>>
>> - merge master and add setStrict() to nFmt class spec
>> - implement suggestions from dFmt review
>> - implement suggestions from cnFmt review
>> - implement suggestions from nFmt review
>> - init
>
> src/java.base/share/classes/java/text/NumberFormat.java line 115:
>
>> 113: * attributes or key/type pairs.
>> 114: * <p>Below is an example of a "US" locale currency format with
>> accounting style,
>> 115: * <blockquote>{@code
>> NumberFormat.getInstance(Locale.forLanguageTag("en-US-u-cf-account"));}</blockquote>
>
> I replaced the previous Thai digits example with an account currency format
> style, as it is probably a more common use case.
Good. I think adding the expectation would be more helpful, such as,
"accounting style, that is, a negative value is enclosed in parentheses instead
of a prepended minus sign."
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18731#discussion_r1567934872
