On Wed, 17 Apr 2024 15:21:32 GMT, Adam Sotona <asot...@openjdk.org> wrote:

>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and 
>> method handles.
>> 
>> This patch converts ASM calls to Classfile API.
>> 
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>> 
>> Any comments and suggestions are welcome.
>> 
>> Please review.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 12 additional 
> commits since the last revision:
> 
>  - applied suggested changes
>  - Merge branch 'master' into JDK-8294960-invoke
>  - Reversion of ClassBuilder changes
>  - Merge branch 'master' into JDK-8294960-invoke
>  - Apply suggestions from code review
>    
>    Co-authored-by: liach <7806504+li...@users.noreply.github.com>
>  - Apply suggestions from code review
>    
>    Co-authored-by: liach <7806504+li...@users.noreply.github.com>
>  - added missing comment
>  - fixed InnerClassLambdaMetafactory for hidden caller classes
>  - performance improvements
>  - consolidation of descriptors handling
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/ee3b164d...304054b9

Thank you for the review.

> How is the performance result compared to using ASM?

I've actually triggered a large set of benchmarks to see the impact. Any hint 
which benchmarks to focus on would be welcome.

Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17108#issuecomment-2061616868

Reply via email to