On Tue, 16 Apr 2024 14:29:13 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> src/java.base/windows/native/libjli/java_md.c line 326:
>>
>>> 324: }
>>> 325:
>>> 326: JLI_TraceLauncher("GetJREPath - attempt to get JRE location from
>>> shared lib of the image\n");
>>
>> Maybe add a trace also in the USE_REGISTRY_LOOKUP section
>
> Hi Christoph, seems the USE_REGISTRY_LOOKUP is currently unused (at least
> without additional defines that are not present usually)
>
> src/java.base/windows/native/libjli/java_md.c:52:#ifdef USE_REGISTRY_LOOKUP
> src/java.base/windows/native/libjli/java_md.c:333:#ifdef USE_REGISTRY_LOOKUP
>
>
> I am not sure if this even works any more. Maybe Alan could comment on this ?
@MBaesken I checked into the building with -DUSE_REGISTRY_LOOKUP as that
compiled in code that the Oracle installer needed when it copied java.exe to
somewhere. This is indeed left over code and can be removed from java_md.c.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18699#discussion_r1570072071
