On Fri, 19 Apr 2024 18:14:05 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4013:
>>
>>> 4011: // Initialize table for unsafe copy memeory check.
>>> 4012: if (UnsafeMemoryAccess::_table == nullptr) {
>>> 4013: UnsafeMemoryAccess::create_table(26);
>>
>> How did you arrive at a table size of 26?
>
> This needs comment
I added 10 to the table size because I knew I was going to add 7 places where a
mark was required for setMemory. I left 3 for safety. The algorithm changed
so only 4 are needed.
The algorithm has since changed, so I changed this to:
`UnsafeCopyMemory::create_table(16 + 4); // 16 for copyMemory; 4 for setMemory`
I did a similar change to all other table creation numbers.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1572841521
