On Fri, 19 Apr 2024 19:47:20 GMT, Naoto Sato <na...@openjdk.org> wrote:

> Unless it is absolutely necessary, I would not fix comments in 
> `jdk.internal.icu` sources, as they are in the upstream code, and would like 
> to minimize the merging effort.

@naotoj Given the policy and strong desire to compile `java.base` with all lint 
warnings enabled and `-Werror`, all of the proposed changes in this PR will 
each individually break the build if/when the warning is added to `javac` and 
we continue to compile `java.base` with the current build settings.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18846#issuecomment-2067246948

Reply via email to