On Tue, 23 Apr 2024 08:09:20 GMT, Alan Bateman <[email protected]> wrote:
>> src/java.base/share/classes/java/io/FileInputStream.java line 211:
>>
>>> 209: * @param name the name of the file
>>> 210: */
>>> 211: private void open(String name) throws FileNotFoundException {
>>
>> If method such as this is private, and only delegates to the 0-suffixed
>> native method, would't it be better to just call the 0-suffixed method
>> directly?
>
> Historically these native methods were wrapped in order to support
> instrumentation, I didn't want to touch in this PR.
And presumably all these 0-suffixed methods will eventually be replaced with
FFM calls anyway.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18598#discussion_r1576561165
