On Thu, 25 Apr 2024 23:03:58 GMT, Chen Liang <[email protected]> wrote:
>> src/java.base/share/classes/java/lang/constant/MethodTypeDescImpl.java line
>> 181:
>>
>>> 179: sb.append(argType.descriptorString());
>>> 180: }
>>> 181: desc =
>>> sb.append(')').append(returnType().descriptorString()).toString();
>>
>> Nit: the rest of the code (and even the new sizing part you added) uses
>> `returnType` instead of `returnType()`
>
> Think the `returnType()` call was for parity with displayDescriptor changes;
> now that we are just in the impl class, either way is fine.
Thanks, fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18945#discussion_r1580645953
