On Mon, 29 Apr 2024 21:54:55 GMT, Joe Wang <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> src/java.base/share/classes/java/io/Console.java line 193:
>
>> 191: * {@code locale}.
>> 192: *
>> 193: * @param locale locale used for formatting
>
> Specify the behavior when locale is null?
Good point. Brought the same wording from `String.format`
> src/java.base/share/classes/java/io/Console.java line 202:
>
>> 200: * string. If there are more arguments than format
>> specifiers, the
>> 201: * extra arguments are ignored. The number of arguments is
>> 202: * variable and may be zero. The maximum number of
>> arguments is
>
> readLine and readPassword don't have this statement (The number of arguments
> is variable and may be zero). Is this statement helpful for those methods as
> well?
Modified each description for `args` consistently.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18923#discussion_r1583891641
PR Review Comment: https://git.openjdk.org/jdk/pull/18923#discussion_r1583892038
