On Tue, 30 Apr 2024 12:23:36 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> Hi, >> During performance optimization work on Class-File API as JDK lambda >> generator we found some static initialization killers. >> One of them is `java.lang.classfile.Attributes` with tens of static fields >> initialized with individual attribute mappers, and common set of all >> mappers, and static map from attribute names to the mappers. >> >> I propose to turn all the static fields into lazy-initialized static methods >> and remove `PREDEFINED_ATTRIBUTES` and `standardAttribute(Utf8Entry name)` >> static mapping method from the `Attributes` API class. >> >> Please let me know your comments or objections and please review the >> [PR](https://github.com/openjdk/jdk/pull/19006) and >> [CSR](https://bugs.openjdk.org/browse/JDK-8331414), so we can make it into >> 23. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > added bug number Yeah, it has no real usage impact but such changes do require CSRs, like https://bugs.openjdk.org/browse/JDK-8305158 for a `final` on `Arrays` class, so you should include the `final` modifier change in your CSR's specdiff. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19006#issuecomment-2085221255