On Wed, 1 May 2024 16:40:31 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments
>
> test/jdk/java/util/Base64/TestEncodingDecodingLength.java line 47:
>
>> 45: public class TestEncodingDecodingLength {
>> 46:
>> 47: private static final int size = Integer.MAX_VALUE - 8;
>
> Perhaps consider size-> SIZE and maybe tweak the name and add an additional
> comment to its purpose
Thanks for the review Lance, both comments should be addressed in
https://github.com/openjdk/jdk/pull/19036/commits/aa25c9a72d218401f70bb19bd0e1d911b19b6361
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19036#discussion_r1586643285
