On Fri, 3 May 2024 19:02:41 GMT, Naoto Sato <na...@openjdk.org> wrote:
> We have a test that checks if `System.console()` returns the correct Console > (or null) from the expected module > (`test/jdk/java/io/Console/ModuleSelectionTest.java`) > Good; then here we should indeed specify `-Djdk.console=jdk.internal.le`. Initially, I suggested an alternative wording (i.e. "default"), but that's inappropriate. After all, the test in question resides in `test/jdk/jdk/internal/jline`. So it only makes sense that it tests that concrete implementation. > Yeah, that would be helpful. > I filed a bug: https://bugs.openjdk.org/browse/JDK-8331681 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19081#discussion_r1589756489
