A peek into TypeKind during the research for #19105 reveals that TypeKind has a few issues: 1. Name mismatch for `newarraycode` and `fromNewArrayCode`: Renamed both to use "newarray code" 2. `fromDescriptor` can throw IOOBE if the input string is empty: changed to throw IAE and added tests. 3. `from(Class)` can be slow due to descriptor computation: added benchmark, will share result in next comment (as it may change with code changes).
The first 2 changes involves API changes, and a CSR has been created. Requesting @asotona for a review. ------------- Commit messages: - whitespace - 8331744: java.lang.classfile.TypeKind improvements Changes: https://git.openjdk.org/jdk/pull/19109/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331744 Stats: 170 lines in 5 files changed: 154 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/19109.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19109/head:pull/19109 PR: https://git.openjdk.org/jdk/pull/19109
