On Tue, 7 May 2024 17:15:43 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> test/jdk/java/io/IO/IO.java line 99:
>>
>>> 97: System.getProperty("test.jdk") + "/bin/java",
>>> 98: "--enable-preview",
>>> 99: "-Djdk.console=gibberish",
>>
>> The test comment suggests this test is testing the default console
>> implementation, but the invocation specifies `-Djdk.console=gibberish` which
>> defaults to java.base. Is this what you intended?
>
> That comment says that this test tests jdk.internal.io.JdkConsoleImpl, which
> belongs to java.base. But, if you read it the way you described, I should
> definitely rephrase it.
Sorry, I read it wrong. Your comment is clear so no need for rewording
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1592840539
