On Sat, 4 May 2024 18:29:25 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> 
wrote:

>> Move all random generators mandated in package `java.util.random` and 
>> currently implemented in module `jdk.random` to module `java.base`, and 
>> remove module `jdk.random`.
>
> Raffaello Giulietti has updated the pull request with a new target base due 
> to a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains seven additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into 8330005
>  - Restrict RandomGenerator service providers to those loadable by the 
> platform class loader.
>  - Typo.
>  - Added @uses javadoc tag for j.u.r.RandomGenerator in java.base.
>  - Terminology changes.
>  - Renamed package jdk.random to jdk.internal.random.
>  - 8330005: RandomGeneratorFactory.getDefault() throws exception when the 
> runtime image only has java.base module

Marked as reviewed by alanb (Reviewer).

src/java.base/share/classes/module-info.java line 426:

> 424:         java.util.Random,
> 425:         java.util.SplittableRandom,
> 426: 

Can you remove this blank files, otherwise the list of service types for this 
provide declaration are all together?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18932#pullrequestreview-2044707607
PR Review Comment: https://git.openjdk.org/jdk/pull/18932#discussion_r1593435059

Reply via email to