On Wed, 8 May 2024 05:29:03 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

> Hello Raffaello, the proposed changes look OK to me. Do you think we should 
> add a jtreg test for this?
> 
> In general, the test coverage for these APIs appears to be missing. I think 
> that can be addressed separately in some of the upcoming changes.

RandomTestCoverage should be testing these APIs but if there are gaps then it 
would be good to add more tests (separate PR of course).  There is a second 
update coming once this PR is integrated, that will change the implementation 
to maybe not use SL.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18932#issuecomment-2099815847

Reply via email to