On Tue, 7 May 2024 18:42:24 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into JDK-8320396-verifier-extension >> - added references to jvms >> - Merge remote-tracking branch 'openjdk/master' into >> JDK-8320396-verifier-extension >> - work in progress >> - work in progress >> - work in progress >> - work in progress >> - work in progress >> - removed string templates from test >> - work in progress >> - ... and 18 more: https://git.openjdk.org/jdk/compare/ae82405f...3ebc780a > > src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java > line 151: > >> 149: var fields = new HashSet<String>(); >> 150: for (var f : classModel.fields()) try { >> 151: if (!fields.add(f.fieldName().stringValue() + >> f.fieldType().stringValue())) { > > We should declare a local record, concat is not safe if we have fields like: > > Loop foo; > oop fooL; > > both will producce `fooLLoop;` Goo point, will fix it, thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16809#discussion_r1595214650
