On Tue, 7 May 2024 18:50:28 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into JDK-8320396-verifier-extension >> - added references to jvms >> - Merge remote-tracking branch 'openjdk/master' into >> JDK-8320396-verifier-extension >> - work in progress >> - work in progress >> - work in progress >> - work in progress >> - work in progress >> - removed string templates from test >> - work in progress >> - ... and 18 more: https://git.openjdk.org/jdk/compare/ae82405f...3ebc780a > > src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java > line 364: > >> 362: className(), >> 363: m.methodName().stringValue(), >> 364: >> m.methodTypeSymbol().parameterList().stream().map(ClassDesc::displayName).collect(Collectors.joining(","))); > > Suggestion: > > m.methodTypeSymbol().displayDescriptor(); > > Can remove the parentheses above. It intentionally prints only parameters and avoids return type. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16809#discussion_r1595232206
