On Wed, 8 May 2024 18:43:41 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and >> three methods to `java.io.Console` for [Implicitly Declared Classes and >> Instance Main Methods (Third Preview)]. >> >> This PR has been obtained as `git merge --squash` of a now obsolete [draft >> PR]. >> >> [Implicitly Declared Classes and Instance Main Methods (Third Preview)]: >> https://bugs.openjdk.org/browse/JDK-8323335 >> [draft PR]: https://github.com/openjdk/jdk/pull/18921 > > Pavel Rappo has updated the pull request incrementally with two additional > commits since the last revision: > > - Specify charset of java.io.IO > - Use system-dependent line separator for Console.println src/java.base/share/classes/java/io/IO.java line 38: > 36: * had been called on that console. > 37: * > 38: * <p> Output from methods in this class uses the character set of the > system Hello Pavel, given that `java.io.IO` exposes both input and output methods and the Charset will be used by both input and output, I think we might have to reword this sentence to make a note of input too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1596380347
