On Fri, 10 May 2024 15:32:07 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> When JLine reads a line, there may be a prompt provided. However, JLine will
>> not interpret the prompt literally, it will handle `%` specially. As a
>> consequence, doing:
>>
>> System.console().readLine("%%s");
>>
>>
>> will not print `%s`, as first `String.format` is used, which will convert
>> `%%s` to `%s`, and then JLine will interpret the `%`. The proposed solution
>> is to duplicate the `%`, so that JLine will print it.
>
> Jan Lahoda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/java/io/Console/ConsolePromptTest.java
>
> Co-authored-by: Adam Sotona <10807609+asot...@users.noreply.github.com>
Looks good to me.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19081#pullrequestreview-2050327444
