On Tue, 14 May 2024 18:38:38 GMT, Sandhya Viswanathan <[email protected]> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rearrange; add lambdas for clarity > > src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1784: > >> 1782: __ subq(tmp, haystack_len); >> 1783: } >> 1784: __ leaq(haystack, Address(rsp, tmp, Address::times_1)); > > This whole code is repeated in two places. Could be made into a function and > used at both places. This is the only place now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1605617739
