On Mon, 20 May 2024 06:41:45 GMT, Axel Boldt-Christmas <abold...@openjdk.org> 
wrote:

> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring 
> deprecated warnings. Testing non-generational ZGC requires the use of a 
> deprecated option.

Hello Axel, the change looks OK to me. I was going to suggest 
`stderrShouldMatch(pattern, boolean ignoreDeprecatedWarning)` as the new method 
instead of `stderrShouldMatchIgnoreDeprecatedWarnings`, but then I see that 
there are also methods with names like this in `OutputAnalyzer`. So this change 
is consistent with those.

`OutputAnalyzer.java` will need a copyright year update before integrating.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19297#pullrequestreview-2065518056

Reply via email to