On Mon, 20 May 2024 15:34:28 GMT, Oussama Louati <d...@openjdk.org> wrote:
>> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
>> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
>> MethodType, and CallSite constants.
>> It currently uses ad-hoc code to process class files and intends to migrate
>> to ASM; but since we have the Classfile API, we can migrate to Classfile API
>> instead.
>
> Oussama Louati has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/java/lang/invoke/indify/Indify.java
>
> Co-authored-by: Glavo <zjx001...@gmail.com>
test/jdk/java/lang/invoke/indify/Indify.java line 201:
> 199: } else if (ex != err) {
> 200: err.addSuppressed(ex);
> 201: }
Suggestion:
err.addSuppressed(ex);
}
test/jdk/java/lang/invoke/indify/Indify.java line 445:
> 443: final char[] poolMarks;
> 444: final Map<MethodModel, PoolEntry> Constants = new HashMap<>();
> 445: final Map<MethodModel, String> IndySignatures = new HashMap<>();
Please use lowerCamelCase field names.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18841#discussion_r1606938989
PR Review Comment: https://git.openjdk.org/jdk/pull/18841#discussion_r1606941104
