> Can I please get a review of this test-only change for addressing > https://bugs.openjdk.org/browse/JDK-8332490? > > The jmh test opens a `InflaterInputStream`, reads the stream contents, but > then doesn't close the stream. This can lead to resource leak which can then > cause OOM as noted in that JBS issue. > > The commit in this PR closes the `InflaterInputStream` when the reads > complete. > > > make test TEST=micro:org.openjdk.bench.java.util.zip.InflaterInputStreams > > and > > > ./build/macosx-aarch64/images/jdk/bin/java -jar > ./build/macosx-aarch64/images/test/micro/benchmarks.jar > org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead > -t max -f 1 -wi 2 -foe true > > pass after this change.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: add a comment ------------- Changes: - all: https://git.openjdk.org/jdk/pull/19340/files - new: https://git.openjdk.org/jdk/pull/19340/files/f8687c3f..42a2d32a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19340&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19340&range=00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19340.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19340/head:pull/19340 PR: https://git.openjdk.org/jdk/pull/19340
