On Tue, 12 Dec 2023 22:21:29 GMT, Joe Darcy <[email protected]> wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing comment
>
> As the core reflection code will encounter record classes compiled before and
> after the javac code generation change, if the old behavior can be triggered
> in javac using `--release $OLD`/`--source $OLD`, that would be helpful to
> include as part of the testing.
> @jddarcy I have uploaded a new commit addressing your comments, thanks
Thanks @vicente-romero-oracle .
As a general comment, please update all the links to "mandated" so that the
text "implicitly declared" get linked to the MANDATED enum constant. The term
"mandated" may not familiar to core reflection readers, but is defined
elsewhere in the platform so I don't think having the term "mandated" appears
in the text in core reflection is necessarily helpful to readers. Concretely,
replace javadoc like
`
implicitly ({@linkplain
java.compiler/javax.lang.model.util.Elements.Origin#MANDATED mandated})
declared`
with
{@linkplain java.compiler/javax.lang.model.util.Elements.Origin#MANDATED
implicitly declared}
Also, before this PR is pushed, please reflow the updated paragraphs so avoid
introducing long lines of text.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17070#issuecomment-2126006488
