On Thu, 23 May 2024 09:46:51 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add type switch to HelloClasslist
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 53:
> 
>> 51: import java.lang.classfile.instruction.SwitchCase;
>> 52: 
>> 53: import jdk.internal.constant.MethodTypeDescImpl;
> 
> Nit - this import seems to be unused, and neither seem to be the changes to 
> `MethodTypeDescImpl`. Is there some use missing? (OTOH, I like the 
> `StaticHolders` for the stuff that relates to the enum-switch special case, 
> for the time being.)

Oops, some leftovers from the optimizations I reverted. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19307#discussion_r1611478359

Reply via email to