On Thu, 23 May 2024 21:50:15 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing review comments > > src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4250: > >> 4248: generate_chacha_stubs(); >> 4249: >> 4250: if ((UseAVX == 2) && EnableX86ECoreOpts && >> VM_Version::supports_avx2()) { > > `#ifdef COMPILER2` around this code to exclude JVMCI only case. You don't need to check `VM_Version::supports_avx2()` because we reset `UseAVX` if avx2 is not supported. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1612361847