On Thu, 30 May 2024 08:34:59 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> @cl4es, do you want me to delete that test file altogether? > > I thought you verified that the non-constant type test still provoke a crash > (on x86) if you back out the code changes in > https://github.com/openjdk/jdk/commit/969f6a37e4649079c7acea1952f5537fd9ba2f0a > ? If so that test is still somewhat useful to guard against future coding > mistakes by verifying that the bail out doesn't mess things up. The constant > type tests have less utility, perhaps. I'd keep it as is unless there's a > strong desire to reduce test runtime (these should be pretty quick). I did verify it. Sorry, momentary lapse of the ability to reason. I'll integrate this PR very shortly then. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19414#discussion_r1620268479
