On Wed, 5 Jun 2024 13:52:43 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 113 commits: >> >> - Mark some tests with requiring packaged modules >> - Correctly set packaged modules default >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - Fix new line in jlink.properties >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - Simplify JLINK_JDK_EXTRA_OPTS var handling >> - Only add runtime track files for linkable runtimes >> - Generate the runtime image link diff at jlink time >> >> But only do that once the plugin-pipeline has run. The generation is >> enabled with the hidden option '--generate-linkable-runtime' and >> the resource pools available at jlink time are being used to generate >> the diff. >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - ... and 103 more: https://git.openjdk.org/jdk/compare/64bbae75...0eb1e48d > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/ResourceDiff.java > line 39: > >> 37: >> 38: /** >> 39: * Class representing a difference between a jimage resource. For all >> intents > > A difference between a jimage resource and ??? Someone might wonder about > that. I've updated the comment a bit to make it clearer. > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/ResourcePoolReader.java > line 33: > >> 31: import jdk.tools.jlink.plugin.ResourcePool; >> 32: >> 33: @SuppressWarnings("try") > > Is this needed? Yes. Otherwise this warning is produced: src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/ResourcePoolReader.java:32: warning: [try] auto-closeable resource ResourcePoolReader has a member method close() that could throw InterruptedException public class ResourcePoolReader implements ImageResource { ^ error: warnings found and -Werror specified ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1628112307 PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1628111856
