On Fri, 7 Jun 2024 07:26:39 GMT, SendaoYan <s...@openjdk.org> wrote: >> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1: >> >>> 1: # >> >> This file change is dubious: >> 1. It does not have any trailing whitespace that can fail the skara checks. >> 2. If the duplicate blank lines in the end of this Makefile is indeed >> problematic (as fixed here), please fix the only other occasion in the JDK, >> which is the Makefile in the parent directory. (Checked with `\n$^\n$\Z` >> pattern in all Makefiles) >> >> Recommended actions: Either >> 1. Revert changes in this file; >> 2. Also update `test/jdk/java/rmi/reliability/benchmark/bench/Makefile` to >> remove the trailing blank line. > > Thanks for the suggestion, the trailing blank line of > `test/jdk/java/rmi/reliability/benchmark/bench/Makefile` has been removed.
Hmm, I'm inclined to keep the newlines at the EOF for both, what do the rest of you think? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1631140457
