On Tue, 11 Jun 2024 16:53:09 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean comments > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java > line 1438: > >> 1436: return >> AccessController.doPrivileged((PrivilegedExceptionAction<Object>) () -> >> Subject.doAs(subject, op), acc); >> 1437: } >> 1438: } catch (PrivilegedActionException pe) { > > What is this catch block for? The cause of a `PrivilegedActionException` > should not be a unchecked exception. Looks like the catch of PrivilegedActionException is no longer necessary, will be removed. Was from from previously using a different doAs or call which needed it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19624#discussion_r1636417022