On Thu, 6 Jun 2024 13:28:55 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review for this change which proposes to remove the >> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that >> JBS issue, in a recent PR discussion, it was suggested >> https://github.com/openjdk/jdk/pull/18786#issuecomment-2147452633 that this >> macro should be removed and the failure of a JNI specified operation (the >> ones for which this macro is being used) should be determined based on a >> `NULL` value returned from that function. The commit in this PR removes this >> macros and updates the call sites to do a `NULL` check. >> >> Given the nature of this change, no new tests have been added. tier1, tier2 >> and tier3 testing passed successfully with these changes. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > improve comments Thank you for the review Alan. I'll integrate this in a few hours. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19576#issuecomment-2167053874
