On Wed, 12 Jun 2024 20:27:05 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - reverted static initialization of ConstantPoolBuilder and CP entries >> - fixed naming conventions > > src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java > line 1148: > >> 1146: } >> 1147: >> 1148: private void emitPopInsn(CodeBuilder cob, BasicType type) { > > We need a TypeKind-aware pop in CodeBuilder too :( Yes, it would be helpful. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17108#discussion_r1642870775