On Tue, 18 Jun 2024 02:00:41 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all, >> Testcase >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` >> run fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root user? It's because during rpmbuild process >> for linux distribution of JDK, root user is the default user to build the >> openjdk, also is the default user to run the `make test-tier1`, this PR make >> this testcase more robustness. >> The change has been verified, only change the testcase, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > change the excption meassges to: Unable to create an unreadable properties > file test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java line 59: > 57: public class MissingResourceCauseTestRun { > 58: public static void main(String[] args) throws Throwable { > 59: if(Platform.isRoot() && !Platform.isWindows()) { Suggestion: if (Platform.isRoot() && !Platform.isWindows()) { ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643875207